Patterns: Refactor the findOrCreate term method #57655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y already exist, and fix bug that allowed different cased labels that could then not be selected
glendaviesnz
added
[Type] Bug
glendaviesnz
requested review from
talldan,
kevin940726,
ntsekouras and
aaronrobertshaw
|
Size Change: +19 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
… once in testing, but haven't been able to replicate, but no disadvantage in having this code just in case
aaronrobertshaw
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @glendaviesnz for picking this up and @ntsekouras for flagging the improvements 👍
The changes LGTM and test as advertised.
✅ Adding a new category that doesn't exist in the taxonomy or core works
✅ When adding a new category the endpoint is correctly called
✅ When adding a second pattern to the new category the endpoint is not called
✅ Creating a new pattern for the core Headers category does result in a user category with a header slug being created
✅ Assigning a new pattern to banners on a site without user categories results in the category being added as Banners matching the core category
ntsekouras
reviewed
Jan 9, 2024
ntsekouras
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactors the findOrCreate term method to not call the API if the user category already exists, and fixes a bug that allowed different cased labels that could then not be selected.
Why?
How?
Testing Instructions
Horses/v2/wp_pattern_categoryendpoint was called and the category was added successfullyHorsescategory and check that/v2/wp_pattern_categorywas not called and the category was successfully assigned to the patternHeadersHeaderswas added with slug ofheaderbannerswith lower caseband check that the category is added asBannersto match the existing core category