Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inconsistent tooltips for block options control #57213

Closed
wants to merge 1 commit into from

Conversation

hbhalodia
Copy link
Contributor

What?

Why?

  • Need to consistency across list view and block toolbar for the Options tooltip dropdown.

How?

  • Removed the Block Name from the list view more options dropdown.

Testing Instructions

  1. Open any post/page in Editor.
  2. Add any block, check the block toolbar. You would see options in tooltip.
  3. Open the list view, hover on dots at the end of a block, you would see now options as a tooltip.

Testing Instructions for Keyboard

  • None.

Screenshots

Block View List View
Screenshot 2023-12-19 at 5 35 41 PM Screenshot 2023-12-19 at 5 35 32 PM
Copy link

github-actions bot commented Dec 19, 2023

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: Needs Accessibility Feedback, [Feature] List View.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

For consistency, removed the block name from the tooltip label in listview of the blocks.
@richtabor
Copy link
Member

Just rebased.

I'd like to double-check with @jeryj on the a11y front. Is it ok to make this consistent with the block toolbar?

Here's a screenshot:

CleanShot 2024-01-23 at 19 55 25
CleanShot 2024-01-23 at 19 55 08

@richtabor richtabor added Needs Accessibility Feedback Need input from accessibility [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jan 24, 2024
@richtabor richtabor requested a review from jeryj January 24, 2024 01:03
@richtabor richtabor changed the title Fix: Inconsistent tooltips for block options control - #57078 Jan 24, 2024
@hbhalodia hbhalodia closed this May 22, 2024
@hbhalodia
Copy link
Contributor Author

  • Would not work on this as issue itself is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Needs Accessibility Feedback Need input from accessibility
2 participants