-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent duplicative offline status indicators #57130
fix: Prevent duplicative offline status indicators #57130
Conversation
Attempt to better communicate the Hook intent.
Prior to making the asynchronous request to the host app across the bridge, it is a better UX to presume network connectivity is present rather than displaying network connectivity messages briefly.
Hoist the `OfflineStatus` indicator from the block list to the editor. The block list is leveraged for inner blocks, which means it rendered nested `OfflineStatus` indicators for blocks with inner blocks. Additionally, the `editor` package feels like an appropriate location for the offline detection component.
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
Flaky tests detected in 30bf2a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7228824395
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
What?
Prevent duplicative offline status indicators from displaying within nested
block lists for inner blocks.
Why?
Fixes wordpress-mobile/gutenberg-mobile#6468. The duplicate indicators are confusing.
How?
Hoist the
OfflineStatus
indicator from the block list to the editor.The block list is leveraged for inner blocks, which means it rendered
nested
OfflineStatus
indicators for blocks with inner blocks.Additionally, the
editor
package feels like an appropriate locationfor the offline detection component.
Testing Instructions
Testing Instructions for Keyboard
N/A, now changes to navigation proposed.
Screenshots or screencast
N/A, no visual changes proposed.