-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve useIsConnected Hook #57079
Conversation
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 59995b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7213769858
|
Prior to making the asynchronous request to the host app across the bridge, it is a better UX to presume network connectivity is present rather than displaying network connectivity messages briefly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for refactoring. 🚀
What?
Improve the recently merged
useIsConnected
Hook to align with projectpractices and cover with automated tests.
Why?
Fixes wordpress-mobile/gutenberg-mobile#6472. Improve approachability and stability of the Hook.
How?
useIsConnected
touseNetworkConnectivity
useNetworkConnectivity
Hook testsuseNetworkConnectivity
HookwithIsConnected
towithNetworkConnectivity
Testing Instructions
Testing Instructions for Keyboard
N/A, no UI changes included.
Screenshots or screencast
N/A, no UI changes included.