Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons: update Medium icon #57073

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

megane9988
Copy link
Contributor

@megane9988 megane9988 commented Dec 14, 2023

What?

Update the Medium logo.

Why?

Medium's logo is changing: https://medium.design/logos-and-brand-guidelines-f1a01a733592
Our Social Icons logo should change too.

#57064

How?

This uses the new logo provided logo assets here : https://www.dropbox.com/s/fg1x3ekgvsn1h7q/Logo.zip?dl=0
https://www.dropbox.com/s/fg1x3ekgvsn1h7q/Logo.zip?dl=0

Testing Instructions

  1. Go to Posts > Add New
  2. Add a new Social Icons block
  3. Add a new Medium block.

Testing Instructions for Keyboard

Screenshots or screencast

image

image

@torounit torounit added the [Block] Social Affects the Social Block - used to display Social Media accounts label Dec 14, 2023
@richtabor richtabor added the [Type] Enhancement A suggestion for improvement. label Dec 14, 2023
@juanfra juanfra linked an issue Feb 1, 2024 that may be closed by this pull request
@t-hamano t-hamano self-requested a review February 21, 2024 04:52
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

The icons are also centered exactly and the colors look correct 👍

logo

Just to be sure, could you rebase this PR using the latest trunk? This is to run the test again and run the bot to collect Props.

Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: megane9988 <megane9988@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: colinduwe <colind@git.wordpress.org>
Co-authored-by: andersnoren <anlino@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd enabled auto-merge (squash) March 7, 2024 03:17
@t-hamano t-hamano self-requested a review March 7, 2024 04:23
@t-hamano t-hamano disabled auto-merge March 7, 2024 04:23
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 7fa6624 into WordPress:trunk Mar 7, 2024
57 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
4 participants