-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Icons: update Medium icon #57073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
The icons are also centered exactly and the colors look correct 👍
Just to be sure, could you rebase this PR using the latest trunk? This is to run the test again and run the bot to collect Props.
b33a540
to
1a8f7f5
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
Update the Medium logo.
Why?
Medium's logo is changing: https://medium.design/logos-and-brand-guidelines-f1a01a733592
Our Social Icons logo should change too.
#57064
How?
This uses the new logo provided logo assets here : https://www.dropbox.com/s/fg1x3ekgvsn1h7q/Logo.zip?dl=0
https://www.dropbox.com/s/fg1x3ekgvsn1h7q/Logo.zip?dl=0
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast