Update/content empty #56898
Draft
Update/content empty #56898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +390 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0016ea8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7138476850
|
youknowriad
reviewed
Dec 8, 2023
| ? contextPost?.title?.rendered || | ||
| 'Back' | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
To be honest, it feels like the back button shouldn't be part of the block breadcrumb but just rendered before it. (It has nothing to do with blocks)
Also, should we do the same in the post-editor, we could write that component in the editor package
nerrad
reviewed
Dec 8, 2023
| withIllustration={ true } | ||
| > | ||
| <p> | ||
| { __( 'This is where your post or page content will go.' ) } |
There was a problem hiding this comment.
Given the block is also used for custom post types, restricting this to "post" or "page" could be confusing for those templates. Also, from a user perspective, the template already appears to have content so the current wording could seem a bit odd.
What about something like:
This is where the dynamic content (for example the blocks from a specific "post" or "page") will go.
There was a problem hiding this comment.
If this placeholder is in a post-type-specific template, it could be more context-aware (and ideally would be using text provided when registering the post type).
youknowriad
reviewed
Dec 14, 2023
| 'is-focus-mode': | ||
| isFocusMode || | ||
| !! editorCanvasView || | ||
| isEditingTemplate, |
There was a problem hiding this comment.
What's the reason for the change here and why it's limited only to the site editor?
|
Alternative version (WIP) for the empty post content block only here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
#55025
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast