Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Dashicons #56872

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Link to Dashicons #56872

merged 1 commit into from
Dec 8, 2023

Conversation

taylorgorman
Copy link
Contributor

@taylorgorman taylorgorman commented Dec 7, 2023

What?

Link "WordPress’ Dashicons" to https://developer.wordpress.org/resource/dashicons/ on https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/.

Why?

So readers don't have to leave and google it.

How?

I added the link.

Testing Instructions

  1. Click the link.

Testing Instructions for Keyboard

  1. Tab to the link and hit Enter.

Screenshots or screencast

I'm hoping shouldn't be necessary.

Copy link

github-actions bot commented Dec 7, 2023

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

1 similar comment
Copy link

github-actions bot commented Dec 7, 2023

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @taylorgorman! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@apeatling apeatling enabled auto-merge (squash) December 7, 2023 17:44
@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Dec 8, 2023
@apeatling apeatling merged commit cb1bbc7 into WordPress:trunk Dec 8, 2023
51 of 56 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 8, 2023
@taylorgorman taylorgorman deleted the patch-1 branch December 17, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
3 participants