#56734 When there is no font, the border should not appear. Display further guidance text. #56825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Display further guidance text.
t-hamano
added
[Type] Bug
|
This PR fixes #54527. |
There was a problem hiding this comment.
Hi @inc2734, thanks for the PR.
Technically, it looks good to me 👍
I want to confirm with @jasmussen about the text displayed when no fonts are activated.
|
Thanks for the ping. We can simplify the message a little, to just say "No fonts installed." 
|
matiasbenedetto
previously requested changes
Dec 28, 2023
packages/edit-site/src/components/global-styles/font-families.js
Outdated
Show resolved
Hide resolved
t-hamano
approved these changes
Jan 11, 2024
t-hamano
dismissed
matiasbenedetto’s stale review
This feedback has been addressed.
|
The readability improvements made in fa96f0f also make sense to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#56734 When there is no font, the border should not appear. Display further guidance text.
Why?
Unnatural border have been displayed.
How?
Ensure that borders are not displayed.
If custom fonts and theme fonts are missing, a message is displayed.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
