Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DimensionControl: Add __next40pxDefaultSize prop #56805

Merged
merged 2 commits into from
Dec 7, 2023
Merged

DimensionControl: Add __next40pxDefaultSize prop #56805

merged 2 commits into from
Dec 7, 2023

Conversation

brookewp
Copy link
Contributor

@brookewp brookewp commented Dec 6, 2023

Part of #46741

What?

Add a new opt-in prop __next40pxDefaultSize to DimensionControl, following the plan outlined in above mentioned PR.

Why?

For more consistency in styling.

How?

A new, temporary __next40pxDefaultSize prop. When the prop is set to true, the inputs will have a height of 40px.

Testing Instructions

In Storybook:

  1. npm run storybook:dev
  2. Set __next40pxDefaultSize to true for DimensionControl
  3. The input height of the component should now be 40px

In the editor

Smoke test the component in the editor; DimensionControl shouldn't have any visible changes for now.
@brookewp brookewp added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 6, 2023
@brookewp brookewp requested a review from a team December 6, 2023 00:25
@brookewp brookewp self-assigned this Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Flaky tests detected in 33de2a9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7122906844
📝 Reported issues:
chad1008
chad1008 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@chad1008 chad1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚢
@brookewp brookewp force-pushed the add/40px-size-dimensioncontrol branch from 6190dce to 33de2a9 Compare December 7, 2023 02:16
@brookewp brookewp enabled auto-merge (squash) December 7, 2023 02:16
@brookewp brookewp merged commit 550966a into trunk Dec 7, 2023
52 checks passed
@brookewp brookewp deleted the add/40px-size-dimensioncontrol branch December 7, 2023 03:06
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
2 participants
@brookewp @chad1008