Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FontSizePicker: Add opt-in prop for 40px default size #56804

Merged
merged 3 commits into from
Dec 7, 2023
Merged

FontSizePicker: Add opt-in prop for 40px default size #56804

merged 3 commits into from
Dec 7, 2023

Conversation

brookewp
Copy link
Contributor

@brookewp brookewp commented Dec 6, 2023

Part of #46741

What?

Add a new opt-in prop __next40pxDefaultSize to FontSizePicker, following the plan outlined in above mentioned PR.

Why?

For more consistency in styling.

How?

A new, temporary __next40pxDefaultSize prop. When the prop is set to true, the inputs will have a height of 40px.

Testing Instructions

In Storybook:

  1. npm run storybook:dev
  2. Set __next40pxDefaultSize to true for FontSizePicker
  3. Look through the different stories and options and ensure the height is 40px for the following components in FontSizePicker:
    • ToggleGroupControl (Default story)
      • Can check Button and UnitControl here too by clicking settings icon
    • RangeControl (Slider story when clicking settings icon)
    • SelectControl (With More Font Sizes story)

In the editor

Smoke test the component in the editor; FontSizePicker shouldn't have any visible changes for now.
@brookewp brookewp added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 6, 2023
@brookewp brookewp requested a review from a team December 6, 2023 00:25
@brookewp brookewp self-assigned this Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Flaky tests detected in 7e3decf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7123278849
📝 Reported issues:
chad1008
chad1008 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@chad1008 chad1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tying into __unstable-large still feels like a good approach on these 🚀 🚢
@brookewp brookewp merged commit f6adf1e into trunk Dec 7, 2023
52 checks passed
@brookewp brookewp deleted the add/40px-size-fontsizepicker branch December 7, 2023 21:13
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
2 participants
@brookewp @chad1008