Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update innerBlocks docs on defaultBlock api and provide example #56727

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sethrubenstein
Copy link
Contributor

I was incorrect when I wrote the original doc here and cast this as an array, its in fact an object. Also, provided a quick code example and a gif of this concept in action. Not sure what the rules are on including images/gifs in Gutenberg docs but thought it might help illustrate what defaultBlock enables.

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

I was incorrect when I wrote the original doc here and cast this as an array, its in fact an object. Also, provided a quick code example and a gif of this concept in action. Not sure what the rules are on including images/gifs in Gutenberg docs but thought it might help illustrate what defaultBlock enables.
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Feb 22, 2024
@ajitbohra
Copy link
Member

@sethrubenstein can you resolve the conflicts?

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org>
Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sethrubenstein
Copy link
Contributor Author

@ajitbohra Updated, I left the gif with the example of how defaultBlock works inplace, feel free to remove, not sure what the rules/guidelines are on gifs in the docs but I thought it might be helpful.

Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethrubenstein thank you, GIF here looks helpful let's keep it. We can change/remove if needed.

@ajitbohra ajitbohra enabled auto-merge (squash) March 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
3 participants