Add top toolbar to distraction free mode #56295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +116 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
This looks good—nice to see it's just a configuration check away. We should look into the editor setup flow soon. |
jeryj
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Working well for me! I had distraction free on before loading this PR, so Idid have to toggle distraction free on/off to get the setting change to take place. I don't think this is worth addressing, but pointing it out just in case.
Looks like the tests only need updated.
jeryj
approved these changes
Nov 20, 2023
|
@draganescu one issue is that if I toggle distraction free to test; don't like it; untoggle—I may think my toolbar is broken because I also need to toggle top toolbar off. |
|
@mtias ideally it should be in the state it was before distraction free was toggled on, but we don't store that anywhere. I wonder if the UX of testing DFM does not imply user understands how that options menu works? In case it implies this then the top toolbar is visibly toggled ON, just like DFM was before diciding they don't like it. It may be a very very niche issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merge of #55787 we're now able to render the top toolbar in the header of the editor UI when distraction free mode is active:
top-toolbar-distraction-free.mp4
I opted in this PR to always enable top toolbar when switching to distraction free mode. There is no reason to turn it off as the whole header auto hides.