-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: Remove screen reader title announcement #56167
Conversation
Size Change: -68 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On trunk, the title is in the aria-live assertive region. On this branch, it's gone.
I'm not convinced this is as cut and dried as this. While the announcement may be unnecessarily verbose and inaccurate now, I think this should get additional opinions before merging. In specific, I think it needs opinions from screen reader users who have less expertise in the editor than Alex - the reasoning here smacks of "I think this works well enough now", without a lot of clear documentation of the experience. |
@joedolson There is also the related issue so we'll see where the discussion goes there. I opened the PR before I was aware of it. I think what's there is certainly not useful for anyone since it is overly verbose and not accurate for half of the pages you visit. Maybe that doesn't mean fully removing it but something needs to happen with it. |
I'd second what Joe Dolson said. I'd think some kind of announcement is necessary especially for users who are not advanced screen reader users and not familiar with the editor. I'd rather focus on making these announcements way less verbose. I do realize verbosity is a problem. If I recall correctly, screen readers (at least some of them) do have a setting to disable the document title announcement. I would love there was something similar for the announcement we use for hte Site editor navigation but I'm not sure it would be feasible? |
I'll close this out and work on a less verbose announcement. There is probably a decent amount of router work required to truly make this worth it, I think we should be more focussed on heading structure vs. announcing the title on every page transition. As noted in the related issue, I'll also take a look at the |
What?
At one time, it was absolutely critical to tell users where they were in the site editor by announcing the page title. This is no longer necessary so this PR removes it.
Why?
Focus is now much more predictable in the editor and the title seems to be announced now. Heading structure also provides lots of context as it didn't before, near the start of FSE.
How?
Removes the code.
Testing Instructions
aria-live
region at the bottom of the page does not display the title as you switch contexts. E.g. viewing a template, pattern, or similar.Testing Instructions for Keyboard
Screenshots or screencast