Package @ariakit/test should be a dev dependency
#56091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WordPress#54939 a new test was added that depends on `@ariakit/test`. But, even though that package is not needed in the production code, it was (accidentally?) added to `dependencies` instead of `devDependencies`. This means everyone using `@wordpress/components` winds up having to install this package. Let's move it to devDependencies where it belongs.
|
Yup, good catch indeed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove an unnecessary dependency of the published
@wordpress/componentspackage on@ariakit/test.Why?
As it is, everyone using
@wordpress/componentswinds up having to install@ariakit/testand its dependencies unnecessarily.How?
Move the dependency to
devDependencies. And, per your linting, apparently devDependencies has to go in the root package.json.Testing Instructions
With
pnpm, you can dopnpm add file:///path/to/gutenberg/packages/componentsin a fresh directory and then check that@ariakit/testis not installed as a dependency.Looks like with npm you'll have to
npm packto create awordpress-components-25.11.0.tgzfile then in the fresh directorynpm install /path/to/wordpress-components-25.11.0.tgz. Then, again, check that@ariakit/testis not installed as a dependency.