-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#55702 - Control dimensions (margin and padding) of the list-item block #55874
#55702 - Control dimensions (margin and padding) of the list-item block #55874
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @valerogarte! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for the PR! ![]() This looks like a nice addition. LGTM and works as expected. Would like a sanity check from @jasmussen before ✅ and 🚢 |
Seems fine to me (and thank you for the PR!). Is there a global styles counterpart? I.e. can I set and forget some dimensions there, and have them apply across all list items? Did not have time to fully test this PR this morning, sorry. CC: @WordPress/gutenberg-design for a broader check. |
I reckon most blocks should support margin/padding. So yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! LGTM.
7c0e310
to
fb2f3a5
Compare
What?
Fixes #55702.
Introduces the ability to adjust the dimensions (margin and padding) of individual list-item blocks within the Gutenberg editor.
Why?
This enhancement addresses the need identified in issue #55702. Previously, users were unable to control the spacing around list items, leading to limited styling options and potential layout inconsistencies. By allowing for margin and padding adjustments, this change provides greater flexibility and precision in design.
How?
Support for dimension controls has been added to the block.json file of the list-item block. This includes the necessary backend changes to enable these features within the block editor's interface.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast