Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNmobile] Fix change log #55786

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[RNmobile] Fix change log #55786

merged 1 commit into from
Nov 2, 2023

Conversation

jhnstn
Copy link
Contributor

@jhnstn jhnstn commented Nov 1, 2023

What?

Place a change note in the unreleased section.

Why?

Perhaps a force push mixed up the branch history?

Testing Instructions

N/A

Testing Instructions for Keyboard

Screenshots or screencast

@jhnstn jhnstn requested a review from fluiddot November 1, 2023 20:21
@jhnstn jhnstn added the [Type] Project Management Meta-issues related to project management of Gutenberg label Nov 1, 2023

## 1.107.0
- [*] Social Icons: Fix visibility of inactive icons when used with block based themes in dark mode [#55398]
- [*] Synced Patterns: Fix visibility of heading section when used with block based themes in dark mode [#55399]
- [*] Classic block: Add option to convert to blocks [#55461]
- [*] Fix error when pasting deeply nested structure content [#55613]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot Still not sure how your commit here 887979a resulted in placing the line item in 1.101.7. My only guess was the force push on that branch confused the git history but not enough to cause a conflict 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting, the PR where the change was introduced added the entry to the Unreleased section (reference).

My only guess was the force push on that branch confused the git history but not enough to cause a conflict 🤷

Yep, I understand that GitHub should have warned about the conflict but it didn't. Thanks @jhnstn for fixing it 🙇 !

@jhnstn jhnstn enabled auto-merge (squash) November 1, 2023 20:52

## 1.107.0
- [*] Social Icons: Fix visibility of inactive icons when used with block based themes in dark mode [#55398]
- [*] Synced Patterns: Fix visibility of heading section when used with block based themes in dark mode [#55399]
- [*] Classic block: Add option to convert to blocks [#55461]
- [*] Fix error when pasting deeply nested structure content [#55613]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting, the PR where the change was introduced added the entry to the Unreleased section (reference).

My only guess was the force push on that branch confused the git history but not enough to cause a conflict 🤷

Yep, I understand that GitHub should have warned about the conflict but it didn't. Thanks @jhnstn for fixing it 🙇 !

@jhnstn jhnstn disabled auto-merge November 2, 2023 12:58
@jhnstn jhnstn enabled auto-merge (squash) November 2, 2023 12:58
@jhnstn jhnstn merged commit 62035e2 into trunk Nov 2, 2023
51 of 52 checks passed
@jhnstn jhnstn deleted the rnmobile/update-changelog branch November 2, 2023 13:14
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
2 participants