Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a brief description to the Footnotes block #54613

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Sep 19, 2023

What and Why?

I noticed there was no description for the Footnotes block. This PR adds a brief one in a similar style to other Core Block descriptions: Display footnotes added to the page.. Happy to adjust based on feedback!

@aurooba aurooba added [Block] Footnotes Affects the Footnotes Block [Type] Enhancement A suggestion for improvement. labels Sep 19, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aurooba This looks good. Please run npm run docs:build locally to build the required doc changes. Then commit those and this should be good to land pending any further feedback.

@aurooba
Copy link
Member Author

aurooba commented Sep 19, 2023

@alexstine thank you for that reminder. I always forget that running npm run build won't run the docs. 😓 Docs build committed!

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aurooba Are these changes related? Don't think so.

packages/compose/README.md

Might want to check them out over latest trunk.

@alexstine
Copy link
Contributor

Alright, let's see if that gets us green checks.

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexstine alexstine merged commit a3f4f02 into WordPress:trunk Sep 27, 2023
47 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 27, 2023
@aurooba
Copy link
Member Author

aurooba commented Oct 7, 2023

@alexstine thanks! I didn't get notified of the comments on these somehow, oops. I appreciate you fixing it up! 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Enhancement A suggestion for improvement.
2 participants