Disable duotone until media is provided in Cover block #54451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Within the Duotone control hook, assess specific blocks (cover and image) and associated media attributes to determine whether Duotone block controls should be displayed. It's worth noting that, since this feature is enabled through block.json, there's no known method for other blocks to conditionally render these controls in a similar manner.
Why?
Resolves #48804
How?
By looking at the block name and the media attributes we know.
Even though this works for now, it might not work well in the future. Media attributes can vary a lot and aren't standardized, making it tricky to set conditions.
Screenshots or screencast
New cover block
![Screenshot 2023-09-14 at 00-32-16 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858655-0f696961-7d4c-400c-9d22-1349af3e441c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4NjU1LTBmNjk2OTYxLTdkNGMtNDAwYy05ZDIyLTEzNDlhZjNlNDQxYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOTMxNTNkYjQ4NzAwMDQzYThmZTBhZWU1ZDVhZWI1MmRlYTMxNzk4YjYzYmEwZTgzOWRlYjg0NDE1ZDg4M2IyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.45XGOYz8uGlC4BDmZlKOVup77XXkp9AJkMQipzvM3Vg)
Cover block with
![Screenshot 2023-09-14 at 00-32-36 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858717-04c0a21a-8691-4666-95af-d26601cc1692.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4NzE3LTA0YzBhMjFhLTg2OTEtNDY2Ni05NWFmLWQyNjYwMWNjMTY5Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYjIzZjhiMDkyMmU0Nzk0NDhhMTJkMjEzMzU3ZDdjNjVjMDVlNzZiOGUwZDFiMGFhNzExM2U2YTFlNjMyNTAyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PnElOpdt2Vj8wtD7DfSvzgNN5aJsenXkziCLsTvcNmI)
useFeaturedImage
Cover block with media
![Screenshot 2023-09-14 at 00-32-54 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858784-60b48779-8179-4cea-8090-a74c21b8fc0f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4Nzg0LTYwYjQ4Nzc5LTgxNzktNGNlYS04MDkwLWE3NGMyMWI4ZmMwZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YTk2Y2FlMjY5YzFmNGI4MzU2YWQ3MGY5YTY2ZjBlNDNjYzZmMDZlNWIwNjdkNjMzNDUyZTlmOTkyNjgyZDVlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.u38HzkE4IjkziMd9edleN5Z-5sWElEC9bQI3yWK6Z1Y)
id
Cover block with overlay color only
![Screenshot 2023-09-14 at 00-33-11 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858818-dc4e33af-d3bc-444f-9483-39100466f7bc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4ODE4LWRjNGUzM2FmLWQzYmMtNDQ0Zi05NDgzLTM5MTAwNDY2ZjdiYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YzJjMWFmZTA5ZGVhODkwZjk5ODE3NzE3MGQ1ZTU4NDVjOTZkZjQ1ODU2MzE2YTU3ZTg0MjEzN2NlZjIyMWM5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.-42QELZ0tHSBLmllu-0LZ-4jE_VxZbKqdk0MVIs7_Ko)
New image block
![Screenshot 2023-09-14 at 00-33-30 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858863-09f47de7-3bad-4bf4-8160-c9d93d2583bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4ODYzLTA5ZjQ3ZGU3LTNiYWQtNGJmNC04MTYwLWM5ZDkzZDI1ODNiZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NjNkMjJiZjNlY2M4MmI0N2MxYzU5NDA2Mzg5MzQ5OTNjYTA4NGQxZTZjNzM0OGM1MWFlZjYyYTgxMzY2YTE2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Ag8UX39vQU4fDsJObgBoGfQbJgY9eOfDR-r2sa2nsVg)
Image block with media
![Screenshot 2023-09-14 at 00-33-46 Edit Page “Sample Page” ‹ gutenberg — WordPress](https://cdn.statically.io/img/private-user-images.githubusercontent.com/375788/267858900-ea1a231e-d076-432e-bcfb-dc27b5559cba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NjYwNDgsIm5iZiI6MTcyMjk2NTc0OCwicGF0aCI6Ii8zNzU3ODgvMjY3ODU4OTAwLWVhMWEyMzFlLWQwNzYtNDMyZS1iY2ZiLWRjMjdiNTU1OWNiYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQxNzM1NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zM2JlN2ZjMjA5ZjNhNGFlNDFmOGRlYjY0NzJkYTRiY2I4NzFhOGI5YWJjOWVlY2ZiYWVjZDMxNzhiNjFmZTI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.vmK3NO579O2Z4AIRRdScrz6URLKuqMa7mjmWbo2F3RM)
id