Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop: Use 'Choose pattern' in placeholder for clarity at narrower widths #54449

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dlh01
Copy link
Contributor

@dlh01 dlh01 commented Sep 14, 2023

What?

In the QueryPlaceholder component, update the button text for choosing a pattern to say "Choose pattern" instead of just "Choose."

Why?

When the editor canvas has a narrower width, the instructions for the Query Loop block placeholder are hidden, making it unclear what the "Choose" button refers to.

How?

Just changing the text.

Testing Instructions

  1. Open the block editor.
  2. Make the editor canvas narrow enough to suppress the instructions by reducing the width of the browser window, or opening the left and right sidebars, or both.
  3. Add a Query Loop block to the content.
  4. Observe that the "Choose" button for selecting a pattern is different.

Screenshots or screencast

Before:

Screenshot 2023-09-13 at 11 58 31 PM

After:

Screenshot 2023-09-14 at 12 01 45 AM
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: Needs Decision, [Block] Query Loop.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@skorasaurus skorasaurus added [Block] Query Loop Affects the Query Loop Block Needs Decision Needs a decision to be actionable or relevant labels Feb 22, 2024
@skorasaurus
Copy link
Member

Sounds good to me, thanks for contributing.

Copy link

github-actions bot commented Feb 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dlh01 <dlh@git.wordpress.org>
Co-authored-by: skorasaurus <skorasaurus@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@richtabor
Copy link
Member

With #63497 aiming the leverage the "Design" panel, it may be more intuitive to use the terminology here: "Choose design".

What do you think?

@dlh01
Copy link
Contributor Author

dlh01 commented Aug 2, 2024

With #63497 aiming the leverage the "Design" panel, it may be more intuitive to use the terminology here: "Choose design".

What do you think?

Sure, that works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block Needs Decision Needs a decision to be actionable or relevant
3 participants