Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider more approachable copy for "Transform to" #54432

Closed
wants to merge 1 commit into from

Conversation

jrtashjian
Copy link
Contributor

@jrtashjian jrtashjian commented Sep 13, 2023

Fixes #42202

Screenshots or screencast

Screenshot 2023-09-13 at 10 53 21 AM
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: Needs Design Feedback.

Read more about Type labels in Gutenberg.

@richtabor richtabor requested review from a team and removed request for ellatrix September 13, 2023 15:03
@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Sep 13, 2023
@jasmussen
Copy link
Contributor

I appreciate the attention to detail here. In principle I like the shorter "turn into", but it's also not a strong opinion on my part, I think the main question is whether the fact that it's been called "transform" for so long means the change will be disorienting. I don't think it will, and I'm happy to defer to a second sanity check.

@jameskoster
Copy link
Contributor

jameskoster commented Sep 14, 2023

+1 attention to detail, and thanks for the submission!

I wonder if 'turn' is a little ambiguous due to the definition overlap with 'rotate'. Obviously it's subjective but I associate 'turn' with changing direction, so it feels slightly out of place in this context. Especially if you think "$label: Block"... "Turn: Paragraph" doesn't really capture the behavior.

I like how explicit 'transform' is.

Other options could be:

  • Swap
  • Switch
  • Convert
  • Replace

But I'm not really convinced that any of those are better than 'Transform' to be honest.

@richtabor
Copy link
Member

I'm 50/50 on this as well. 😅

@apeatling
Copy link
Contributor

Transform seems pretty clear. I would personally have a slight preference for "Change into".

@jrtashjian
Copy link
Contributor Author

We can close this if there is a consensus that no changes should be made.

I didn’t even notice the “needs copy review” label on the original issue, so I shouldn’t have submitted a PR for this. But hey, at least we have one less issue now! 😄

@apeatling
Copy link
Contributor

Closing this one since I think consensus is that Transform is fine.

@apeatling apeatling closed this Nov 30, 2023
@jrtashjian jrtashjian deleted the jrtashjian/issue42202 branch November 30, 2023 19:41
@jrtashjian
Copy link
Contributor Author

I don't have the ability to, but we should close the associated issue (#42202) as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
5 participants