Make the Back link extensible on theme previews #54174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +24 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1f2149b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6080738852
|
7 tasks
|
I think there's a simpler option: #54242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the Back link on Block Theme Previews extensible with the settings store.
Why?
Sometimes, 3rd party apps want to extend the Back link, as going back to
/themes.phpdoes not always make sense. c.f. Automattic/wp-calypso#80595How?
Added
__experimentalThemePreviewBackLinkto the settings store same as__experimentalDashboardLink.I did not use
dashboardLinkhere because a user does not go back to the "dashboard" in the theme previews flow.Testing Instructions
It's rather a test to ensure existing functionality.
/themes.phpScreenshots or screencast