Font Library: changing the upload directory to wp-content/fonts

[jffng]

What?

Fixes #53965, simplified alternative to #54076 as suggested by @matiasbenedetto .

Why?

We want the fonts to be stored in wp-content/fonts instead of wp-content/uploads/fonts.

How?

Changes the set_upload_dir and get_fonts_dir functions.

Testing Instructions

1. Run the unit tests locally (npm run test:unit:php)
2. Test manually in your console by following these instructions: Fonts Library: change upload directory to wp-content/fonts #54076 (comment)

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts/font-library/class-wp-font-library.php
❔ phpunit/tests/fonts/font-library/wpFontFamily/base.php
❔ phpunit/tests/fonts/font-library/wpFontFamily/install.php
❔ phpunit/tests/fonts/font-library/wpFontFamily/uninstall.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontsDir.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/setUploadDir.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/installFonts.php

[github-actions]

Flaky tests detected in 538d030.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6053126918
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[matiasbenedetto]

I made a small change regarding avoiding one hardcoded variable in the tests base class.

Apart from that it tests and works as expected. LGTM
Thanks for working on this 🚀