Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Utils: Allow overriding username/password #53267

Merged
merged 1 commit into from
Oct 2, 2023
Merged

E2E Utils: Allow overriding username/password #53267

merged 1 commit into from
Oct 2, 2023

Conversation

juhi123
Copy link
Contributor

@juhi123 juhi123 commented Aug 2, 2023 •
edited by swissspidy
Loading

What?

WP_ADMIN_USER was hardcoded in config.ts. Fixes #52598

Why?

Because of hardcoded values, the credential variables was not passing through .env file and was giving 400 error

How?

Testing Instructions

Add .env file in your test directory and run the tests, don't forget to add require( 'dotenv' ).config(); in your playwright.config.ts
@juhi123 juhi123 changed the title Fix REST API giving 400 Error when passing Aug 2, 2023
@juhi123 juhi123 changed the title Fix REST API giving 400 Error when passing URL through .env file Aug 2, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] E2E Test Utils /packages/e2e-test-utils labels Aug 2, 2023
@Mamaduka Mamaduka mentioned this pull request Oct 2, 2023
Closed
@swissspidy swissspidy changed the title Fix REST API giving 400 Error when passing URL and credentials through .env file Oct 2, 2023
@Mamaduka Mamaduka merged commit 4968465 into WordPress:trunk Oct 2, 2023
50 of 51 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Test Utils /packages/e2e-test-utils [Type] Bug An existing feature does not function as intended
3 participants
@juhi123 @swissspidy @Mamaduka