Migrate Allowed Block Test to Playwright #53171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooja-muchandikar
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
[Package] E2E Tests
|
Hi @Mamaduka, I hope you are doing great! Could you please review this PR? And let me know if there are any suggestions. Thanks! |
Mamaduka
reviewed
Jul 31, 2023
There was a problem hiding this comment.
I'll try to do a more in-depth review later this week, but at a glance, I think there's room to improve locators and assertions.
- Use web first assertion and get rid of
not.toBeNull()andtoBeUndefined()- https://playwright.dev/docs/best-practices#use-web-first-assertions. - Prefer accessible and user-facing attributes to XPath and CSS classes - https://playwright.dev/docs/best-practices#prefer-user-facing-attributes-to-xpath-or-css-selectors.
Some of those are already covered in the block editor handbook - https://developer.wordpress.org/block-editor/contributors/code/testing-overview/e2e/.
|
Sure @Mamaduka! Thanks for sharing I will work and push the changes. |
|
Hi @Mamaduka, All feedbacks are been addressed! |
Mamaduka
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Thank you, @pooja-muchandikar!
I left few more notes, but in general migration looks good 👍
Mamaduka
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate allowed-blocks.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/plugins/allowed-blocks.spec.js