Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return for DEWP code examples #52836

Closed
wants to merge 1 commit into from
Closed

Missing return for DEWP code examples #52836

wants to merge 1 commit into from

Conversation

widoz
Copy link
Contributor

@widoz widoz commented Jul 21, 2023

The examples for the Dependency Extraction Webpack Plugin for the functions requestToExternal and requestToHandle are missing to return request. If someone copy/paste the code as a starting point they'll loose all other dependencies.

The examples for `requestToExternal` and `requestToHandle` are missing to return `request`. Someone copy/paste the code might have dependencies missed because of this
@widoz widoz requested a review from gziolo as a code owner July 21, 2023 12:46
@widoz widoz changed the title Missing return for DEWP code example Jul 21, 2023
@widoz widoz closed this Jul 21, 2023
@widoz widoz deleted the patch-4 branch July 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant