Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect function example in README #52834

Closed
wants to merge 1 commit into from
Closed

Incorrect function example in README #52834

wants to merge 1 commit into from

Conversation

widoz
Copy link
Contributor

@widoz widoz commented Jul 21, 2023

What?

Fix incorrect function example in the Dependency Extraction Plugin for requestToHandle.

Why?

Reduce cognitive effort to understand the code example

How?

Changing the function name in the example

Testing Instructions

Not relevant

Testing Instructions for Keyboard

Not relevant

Screenshots or screencast

Not Relevant
@widoz
Incorrect function example in README
f4241a5 
Fix incorrect function example in the Dependency Extraction Plugin for `requestToHandle`.
@widoz widoz requested a review from gziolo as a code owner July 21, 2023 11:59
@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers [Package] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin labels Jul 21, 2023
Mamaduka
Mamaduka approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ✅
@widoz widoz closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Developer Documentation Documentation for developers
2 participants
@widoz @Mamaduka