Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct function name handleFileChange is replaced by wrong function name #52250

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Correct function name handleFileChange is replaced by wrong function name #52250

merged 1 commit into from
Sep 6, 2023

Conversation

gvgvgvijayan
Copy link
Contributor

What?

onFileChange property is having the value as handleFileChange but in paragraph explanation wrongly used onFileChange

Why?

The context of invoking non existing function in the explanation may cause confusion for the reader.
jorgefilipecosta
jorgefilipecosta approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @gvgvgvijayan 👍 Thank you!
@jorgefilipecosta jorgefilipecosta merged commit 7d44efe into WordPress:trunk Sep 6, 2023
49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 6, 2023
@gvgvgvijayan
Copy link
Contributor Author

Thanks @jorgefilipecosta 🙂
@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Package] Media Utils /packages/media-utils [Feature] Media Anything that impacts the experience of managing media labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Package] Media Utils /packages/media-utils [Type] Enhancement A suggestion for improvement.
3 participants
@gvgvgvijayan @jorgefilipecosta @mikachan