Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fill="none" from pinSmall icon #51979

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Remove fill="none" from pinSmall icon #51979

merged 1 commit into from
Jun 27, 2023

Conversation

miminari
Copy link
Member

What?

Remove fill="none" from pinSmall icon

Why?

pinSmall Icon can't see in the Storybook.
see: https://wordpress.github.io/gutenberg/?path=/docs/icons-icon--default

Testing Instructions

  1. npm run storybook:dev
  2. check http://localhost:50240/?path=/docs/icons-icon--default

Screenshots or screencast

スクリーンショット 2023-06-27 22 03 52
@miminari miminari added the [Package] Icons /packages/icons label Jun 27, 2023
@t-hamano t-hamano self-requested a review June 27, 2023 14:03
t-hamano
t-hamano approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍Thanks for your contribution!
@t-hamano t-hamano merged commit f332703 into WordPress:trunk Jun 27, 2023
50 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 27, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@miminari @sethrubenstein
Remove fill="none" from pinSmall icon (WordPress#51979)
c1f25f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons
2 participants
@miminari @t-hamano