Fix query-no-results block from showing when their is one search result #47793 #50942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows inner blocks to operate on the correct query when checking for the state of the loop.
What?
This is an attempt at addressing #47793
Store the
post-template
block's query in globals. Inpost-content
andpost-featured-image
blocks, use the query if available instead of the global one.in_the_loop
would fail. This PR should be tested to see if it reintroduces the bug or not.Why?
This change is to avoid manipulating the global
wp_query
in thepost-content
andpost-featured-image
blocks.These blocks are typically used as inner blocks of the
post-template
block. When thepost-template
block is configured to use the globalwp_query
it'll create a clone of it instead of using it directly, so the two aforementioned blocks shouldn't operate on the global one.How?
In
post-template
, the query is stored in a global. In the blockspost-content
andpost-featured-image
this query is retrieved and used instead of using the functions for the global query.Testing Instructions