Removed gutenberg Directory Name Expectation
#50894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some of the
wp-envunit tests fail when the developer has Gutenberg checked out into another directory.Closes #50800.
Why?
The tests were using
path.resolve()in many places but expectingparseSourceString()to set thebasenametogutenberg. Since thebasenamecomes from the directory name, this doesn't work when the directory is renamed.How?
Removes the relative paths and updates tests to work without
gutenbergbeing the base name. I initially took a look at mockingparseSourceString()but it is used in so many places that it was unwieldy.Testing Instructions
npm run test:unit packages/envwith the directory beinggutenberg.npm run test:unit packages/envagain, confirm that tests still pass.