-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same styles for block highlight and hover #50824
Conversation
@richtabor The white color that list view uses seems to only be for dark themes. With this change, hovering and highlighting will both use that white color for dark themes. Another thing is that this makes the styles for hover/highlight similar to block selection. Yet block selection doesn't apply the same white color in dark themes. Perhaps it should? |
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Flaky tests detected in 0624ade. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5042350687
|
Would echo, probably good to keep this behavior intact. Dark themes, in this case, also applies to the Cover block when the background is deemed "dark". |
This PR maintains that behavior, extending the highlighted styling (including the white for dark backgrounds) to hover, right? |
Yep. But I think the selected block is still blue for dark themes right now, so I'm wondering if that should change too. I'm also not sure what a good theme to test this in would be. The dark variations of TT3 don't seem to trigger the white selection border. update: I'm actually seeing a white selection/hover/highlight border consistently for some blocks (group), but not others (paragraph, heading). I guess the best thing is to make this consistent? |
Yes certainly. Could be a follow-up I suppose. I'd expect the highlight/hover/selection of blocks to be either the admin color or the white (if a dark background block/theme). |
What?
Closes #50747
Uses the same styles for highlighted and hovered blocks (in the site editor).
Why?
See #50747 for reasoning.
How?
Copy/paste the styles.
Testing Instructions
The styles should be the same.
Screenshots or screencast
Kapture.2023-05-22.at.14.00.54.mp4