[RNMobile] Add embed webview for Android #50440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 50b6f41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4928801336
|
This was referenced May 8, 2023
jhnstn
force-pushed
the
rnmobile/add-embed-webview
branch
from
f2580b7
to
8fbeb8c
Compare
Fix renaming --ammend
jhnstn
force-pushed
the
rnmobile/add-embed-webview
branch
from
4c3ead4
to
46d29ff
Compare
12 tasks
jhnstn
commented
May 9, 2023
| @Override | ||
| public void onPageStarted(WebView view, String url, Bitmap favicon) { | ||
| // Center the embed with a black background; | ||
| String css = "body{margin:0;background:#000;display:flex;align-items:center;}"; |
There was a problem hiding this comment.
The fullscreen preview on iOS has a black background by default so there is no need to check the user theme preference .
fluiddot
reviewed
May 9, 2023
There was a problem hiding this comment.
@jhnstn Tested via wordpress-mobile/WordPress-Android#18383 (review). I added some comments but shouldn't block the PR.
Not sure how feasible would be but it would be great automatically play the video once the WebView is launched. I found it a bit weird that you have to tap two times on the play button to actually play the video. WDYT? I wouldn't consider this a blocker but an interesting QoL to incorporate.
.../react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Outdated
Show resolved
Hide resolved
...main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergEmbedWebViewActivity.java
Outdated
Show resolved
Hide resolved
|
Thanks for the reviews @fluiddot !
I had a similar thought about the autoplay. I know we can trigger a play event via VideoPress and it seems fairly straight forward to inject JS into the WebView. I didn't explore that in the interest of getting a MVP working. I can look into that as a follow up. |
These are no longer overriden in the main Android app
fluiddot
reviewed
May 10, 2023
There was a problem hiding this comment.
Tested via wordpress-mobile/WordPress-Android#18383 (review). Since I spotted some issues there, I'll hold the approval until we tackle them.
jhnstn
force-pushed
the
rnmobile/add-embed-webview
branch
from
0280d01
to
50b6f41
Compare
fluiddot
approved these changes
May 10, 2023
There was a problem hiding this comment.
Approved via wordpress-mobile/WordPress-Android#18383 (review).
|
@fluiddot you can ignore the re-request to review. I meant to re-request a different PR |
cbravobernal
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes wordpress-mobile/gutenberg-mobile#5509
Adds a full screen embed preview for Android.
Depends on:
Related:
Why?
The
react-native-webviewon Android has event propagation issues when nested inside aPressablecomponent. As a work around we need an Android WebView to render interactive embed content.How?
Adds a new Android Activity to render embed content in a native WebView.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast