Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for eslint-plugin validating dependencies in useSelect and useSuspenseSelect hooks #50247

Conversation

ecgan
Copy link
Contributor

@ecgan ecgan commented May 2, 2023

What?

This is a follow-up to #49900 (comment).

In this PR, we add changelog that is missing from PR #49900. The changelog is done by following https://github.com/WordPress/gutenberg/tree/f795ebee6977df1fc0b3578297c39e9bba1ebb91/packages#maintaining-changelogs

Testing Instructions

Just adding a line of changelog. No testing required.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for including the changelog.

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label May 2, 2023
@ecgan
Copy link
Contributor Author

ecgan commented May 2, 2023

@gziolo , thanks for the approval. I am not authorized to merge the PR (see screenshot below), could you help to merge this please? 🙏

image

@gziolo gziolo merged commit 639e57e into WordPress:trunk May 2, 2023
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 2, 2023
@ecgan ecgan deleted the add/changelog-eslint-validate-useSelect-dependencies branch May 2, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
2 participants