Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copilot markers to PR template #50063

Closed
wants to merge 4 commits into from

Conversation

priethor
Copy link
Contributor

@priethor priethor commented Apr 25, 2023

What?

🤖 Generated by Copilot at 0db1c55

Updated the pull request template to use GitHub Copilot features. This can help create more informative and consistent pull requests.

Why?

To automatically provide PRs with a GitHub copilot summary (What) and detailed description (How)

How?

🤖 Generated by Copilot at 0db1c55

  • Enable automatic summary and description generation for pull requests (link,link)

Testing Instructions

  1. Open a PR
  2. Fill the PR description as usual without removing the copilot:xxx markers.

Screenshots or screencast

This PR description shows how it would look like when opening a PR! 🙂

@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg Developer Experience Ideas about improving block and theme developer experience labels Apr 25, 2023
@priethor priethor marked this pull request as ready for review April 25, 2023 14:56
@youknowriad
Copy link
Contributor

To be completely honest, in my short period testing it. I find it useful to get a starting point but I expected better results. So I'm not entirely sure that we should rely on it too much otherwise we might get lazy and lose a bit of quality in PR descriptions.

@apeatling
Copy link
Contributor

Yes I was just going to say a similar thing to Riad. They tend to be a bit matter of fact and don't add a huge amount of value. Maybe a better idea would be to include them in a commented out section to let folks know they can use them if they want?

@gziolo
Copy link
Member

gziolo commented Apr 26, 2023

I’m skeptical but curious about how it will work in practice. Some people started using AI to write these descriptions, so maybe we should give it a try but, at the same time, put more emphasis on „why” section that AI doesn’t know 😀

@andrewserong
Copy link
Contributor

Just echoing the other comments, but one of the big limitations of the copilot summary is that it can provide a factual "what" but not explain the real purpose behind a PR, so I tend to find the summaries either difficult to parse, or not quite useful enough. I much prefer reading a human-written summary to understand what the intent of the PR author is.

Maybe a better idea would be to include them in a commented out section to let folks know they can use them if they want?

Keeping it in the commented out section sounds like a good option, so folks can opt in to using it if they'd like.

@priethor
Copy link
Contributor Author

Maybe a better idea would be to include them in a commented out section to let folks know they can use them if they want?

Does it work when commented out? I was trying it in this same PR so that it wasn't intrusive for folks not used to it, but the bot didn't kick in.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it in case you want to give it a try. We can revisit it in a few days. It's easy to revert all these changes.

@apeatling
Copy link
Contributor

Does it work when commented out? I was trying it in this same PR so that it wasn't intrusive for folks not used to it, but the bot didn't kick in.

I was thinking more in a commented out section "You can use the following copilot commands if you wish: X, Y, Z", that could then be copied/pasted outside of the commented section if desired. Just a thought.

@andrewserong
Copy link
Contributor

I was thinking more in a commented out section "You can use the following copilot commands if you wish: X, Y, Z", that could then be copied/pasted outside of the commented section if desired. Just a thought.

That's what I was thinking, too.

@priethor
Copy link
Contributor Author

I see now, thanks. That could be good for helping contributors get familiar with copilot, but on the other hand, it makes it more work in general than just typing copilot:summary once you know the marker. I think it's better not to add things to the template unless they are direct and simple; if we agree it's better to add instruction rather than the marker, I'd lean towards adding nothing at all 😅

@apeatling
Copy link
Contributor

My opinion isn't super strong, so happy to go with consensus. My argument would be that if every PR has Copilot generated content it's probably worse for PR readability at this point. That might change in the future if it gets better.

@priethor
Copy link
Contributor Author

Closing this as GitHub is ending support for copilot in PRs.

@priethor priethor closed this Nov 17, 2023
@youknowriad youknowriad deleted the add/copilot-markers-in-pr-template branch November 17, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Project Management Meta-issues related to project management of Gutenberg
5 participants