Try: create new Tabs component using @radix-ui/react-tabs & shim TabPanel
#49874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.79 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
👋 Just wanted to make sure this PR got tracked by me for accessibility review. Really important to not break UX for this component considering there is an effort to roll it out to replace the fake tab buttons. Please let me know when ready for review. Thanks. |
|
Closing in favor of #51551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrate internals of
TabPanelto use@radix-ui/react-tabswhile keeping the existing API.Why?
How?
Testing Instructions
tbd
Testing Instructions for Keyboard
Screenshots or screencast