[RNMobile] Update Sandbox component #49663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
added
the
Mobile App - i.e. Android or iOS
jhnstn
commented
Apr 7, 2023
jhnstn
commented
Apr 7, 2023
| ( message ) => { | ||
| let data = message?.nativeEvent?.data; | ||
|
|
||
| try { |
There was a problem hiding this comment.
I omitted the existing string check. The try is robust enough to handle non strings.
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
3 tasks
|
Flaky tests detected in 43ef2da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4639706150
|
fluiddot
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
LGTM 🎊 !
I followed the testing instructions from Automattic/jetpack#29990 and confirmed that worked as expected. Similarly, I tested the Embed block using different providers and didn't find any regressions.
I added some minor comments but none should be considered blockers.
Follow testing instructions on
Verify that native embed blocks are performing as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the following enhancements to the native
Sandboxcomponent:WebViewcomponent to allow the parent component to inject javascriptWebViewwindowWhy?
WebViewmethods e.g. injecting JavaScript after the component has mountedwindoweventsHow?
forwardRefcallonWindowEventswhich accepts an object of the form{ 'event_type' : eventHandlerFunction }Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast