Update Spacer block minimum width/height #49188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Package] Block library
|
Size Change: +73 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevents Spacer blocks from being zero width or height and sets a practical minimum size that varies according the the unit. Secondarily, some changes propose to share more logic between web and RN and eliminate one inconsistency between the two.
Why?
How?
The hook
useCustomUnitswas already in use for the Spacer block. Its return value includes astepvalue for each of the units and that has been coopted for use as the minimum size. The constant that was previously used for all the units was0is changed to1and only used as the fallback in casestepdoes not exist for a unit (very edge case).Testing Instructions
Testing Instructions for Keyboard
0.Screenshots or screencast
Before
spacer-minimums-before.mp4
After
spacer-minimums-after.mp4