components/utils/font: refactor away from lodash .get
#48629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Type] Code Quality
|
Size Change: +3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d4b9bca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4303096173
|
tyxla
requested changes
Mar 1, 2023
| @@ -14,5 +9,5 @@ import FONT from './font-values'; | |||
| * @return {string} Font rule value | |||
| */ | |||
| export function font( value ) { | |||
| return get( FONT, value, '' ); | |||
| return FONT[ value ] ?? ''; | |||
There was a problem hiding this comment.
Unfortunately, this won't work; value could contain dots that define a nested path, for example:
We'll need to parse and account for those when retrieving the field value. You could borrow the getValueFromObjectPath() helper from #48491 which does essentially that.
There was a problem hiding this comment.
I don't think it's a path. The keys of the FONT map contain dots, too. The JSDoc mentions its expecting one of those keys. Think we're good in this case.
There was a problem hiding this comment.
Glad this was a false alarm. Thanks for double-checking. I've confirmed that you're correct. 👍
tyxla
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.get()from thefonthelper utility in the components package.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using nullish coalescing instead.
Testing Instructions
npm run storybook:dev) and inspect all the stories of theInputControlcomponent. Make sure it looks exactly the same as here: InputControl (Storybook).