Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation: refactor to TypeScript #48580

Closed

Conversation

hbhalodia
Copy link
Contributor

What?

  • PR Changes .js file to .ts

Why?

How?

  • Changed to .ts file and pass the build process.
@hbhalodia hbhalodia marked this pull request as ready for review February 28, 2023 06:05
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 28, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hbhalodia! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Code Quality Issues or PRs that relate to code quality label May 9, 2023
@t-hamano t-hamano added the [Package] Components /packages/components label Dec 8, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Dec 8, 2023

Hi @hbhalodia,

Sorry for the delay in checking this PR. In the latest Gutenberg, the Animation component seems to have already been migrated to TypeScript. Therefore, I would like to close this PR.

Thank you for your contribution 👍

@t-hamano t-hamano closed this Dec 8, 2023
@hbhalodia hbhalodia deleted the refactor/animation-to-typescript branch December 8, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
3 participants