Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced parenthesis in Element README #47700

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Feb 2, 2023

What?

  • Fix unbalanced parenthesis in Element README

Why?

I copy and pasted the example on https://github.com/WordPress/gutenberg/tree/trunk/packages/element and got a syntax error.

How?

Removing the extra parenthesis

Testing Instructions

Manual inspection

Testing Instructions for Keyboard

Screenshots or screencast

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexstine alexstine added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers [Package] Element /packages/element labels Feb 3, 2023
@alexstine
Copy link
Contributor

@mreishus Looks like static checks did catch a bug. You will need to fix this up.

There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!

@mreishus
Copy link
Contributor Author

mreishus commented Feb 3, 2023

Should be fixed now

@alexstine alexstine merged commit 4f94f09 into WordPress:trunk Feb 4, 2023
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Element /packages/element [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
2 participants