Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add option to align list block [#39071] #47412

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

hbhalodia
Copy link
Contributor

What?

  • This PR adds the support to text alignment for the list type block with option to add list position inside or outside.

Why?

How?

  • This PR adds the Alignment Toolbar (for text alignment) and custom toolbar (for inside, outside position)

Testing Instructions

  • You can see below screencast for testing and step by step instructions.

Testing Instructions for Keyboard

  • Nothing extra for keyboard, the new implementation is accessible same way as previously it was.

Screenshots or screencast

ListBlock.webm
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 25, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hbhalodia! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] List Affects the List Block label Feb 15, 2023
@hbhalodia hbhalodia marked this pull request as ready for review December 14, 2023 09:20
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Block] List, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
2 participants