Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the name of the custom field button labels #47407

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Adjust the name of the custom field button labels #47407

merged 6 commits into from
Jun 14, 2023

Conversation

SavPhill
Copy link
Contributor

@SavPhill SavPhill commented Jan 25, 2023 •
edited
Loading

The current button labels do not accurately describe the behaviour of the button, because the value of the custom fields are still retrievable whether or not the button is 'enabled' or 'disabled'.

Fixes #47406.

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@SavPhill
Adjust the name of the custom field button labels
b218dd2 
See Issue WordPress#47406 The current button labels do not accurately describe the behaviour of the button, because the value of the custom fields are still retrievable whether or not the button is 'enabled' or 'disabled'.
@Mamaduka
Copy link
Member

@SavPhill, it looks like unit test snapshot needs an update. You can run following command in the Gutenberg plugin directory:

npm run test:unit -- packages/edit-post/src/components/preferences-modal/options/test/enable-custom-fields.js --updateSnapshot
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Needs Copy Review Needs review of user-facing copy (language, phrasing) [Package] Edit Post /packages/edit-post labels Jan 25, 2023
@kristastevens
Copy link

Hello! Answering the copy review bat signal.

Label renaming looks good to me. 👍
Mamaduka
Mamaduka requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SavPhill, the unit tests are still failing. We'll need to fix any test failures before merging the code.
@SavPhill
Copy link
Contributor Author

@SavPhill, the unit tests are still failing. We'll need to fix any test failures before merging the code.

I have updated the Snapshot to match.
Mamaduka
Mamaduka approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SavPhill!
@Mamaduka Mamaduka merged commit 078ede8 into WordPress:trunk Jun 14, 2023
48 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 14, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@SavPhill @sethrubenstein
Preferences: Adjust the name of the custom field button labels (WordP…
e968199 
…ress#47407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Package] Edit Post /packages/edit-post [Type] Enhancement A suggestion for improvement.
3 participants
@SavPhill @Mamaduka @kristastevens