DimensionControl(Experimental): refactor to TypeScript
#47351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Type] Code Quality
|
Size Change: +5 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
flootr
force-pushed
the
refactor/dimension-control-to-typescript
branch
from
d171d23
to
6ce1240
Compare
|
Flaky tests detected in b74c44a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4355452047
|
ciampo
reviewed
Jan 27, 2023
There was a problem hiding this comment.
Thank you for working on this, Markus!
On top of the inline comments, here's some additional feedback:
- we should also look at updating the README:
- the current example code is very tightly coupled with the editor. We should probably find a good compromise between showing a real-world use case, but without using APIs and specific references to the block editor
- We should keep README / JSDoc in types.ts / code implementation in sync, especially regarding the props (description, optionality, default value)
- We should keep the example snippet in sync between the README and the JSDoc for the default export
- For the expected current format of the README file, you can refer to the CONTRIBUTING guidelines
flootr
force-pushed
the
refactor/dimension-control-to-typescript
branch
from
f5189ee
to
c7dba4e
Compare
ciampo
reviewed
Feb 6, 2023
There was a problem hiding this comment.
Looking good! I just left a few more minor comments :D Also quoting past Marco about some misc feedback — let me know in case any of it isn't clear!
- the current example code is very tightly coupled with the editor. We should probably find a good compromise between showing a real-world use case, but without using APIs and specific references to the block editor
- We should keep README / JSDoc in types.ts / code implementation in sync, especially regarding the props (description, optionality, default value)
- We should keep the example snippet in sync between the README and the JSDoc for the default export
- For the expected current format of the README file, you can refer to the CONTRIBUTING guidelines
flootr
force-pushed
the
refactor/dimension-control-to-typescript
branch
from
a3daf5a
to
b423a41
Compare
|
@ciampo I think your feedback should be addressed. Please let me know if there's anything else you'd like me to adjust. |
ciampo
approved these changes
Mar 2, 2023
ciampo
reviewed
Mar 3, 2023
flootr
force-pushed
the
refactor/dimension-control-to-typescript
branch
from
b423a41
to
317cd47
Compare
ciampo
reviewed
Mar 7, 2023
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
flootr
force-pushed
the
refactor/dimension-control-to-typescript
branch
from
42a38d6
to
b74c44a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
DimensionControlcomponent to TypeScriptWhy?
Part of #35744
How?
.tsxand created atypes.tsfile with relevant typesTesting Instructions
Wit this PR we introduce a story for this component. Please verify it behaves as expected.