Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed line break within the code block #46920

Merged
merged 20 commits into from
Jul 10, 2023
Merged

Conversation

SavPhill
Copy link
Contributor

@SavPhill SavPhill commented Jan 5, 2023

What?

There is a line break within the code block.

Why?

I have removed the line breaks as the line break during the class are not necessary.

How?

Testing Instructions

Navigate to: https://developer.wordpress.org/block-editor/explanations/architecture/styles/#block-styles

See the unnecessary line breaks within the second code block.

Testing Instructions for Keyboard

Screenshots or screencast

@skorasaurus
Copy link
Member

thanks, looks good to me.

@SavPhill
Copy link
Contributor Author

SavPhill commented Jun 4, 2023

Giving this PR a bump as it's 5 months without any movement.

@annezazu annezazu enabled auto-merge (squash) June 5, 2023 19:59
@annezazu
Copy link
Contributor

annezazu commented Jun 7, 2023

Hey there. Can you try merging in latest trunk? Right now, some of the automated items have failed/didn't report and it's making it so it can't be merged.

@SavPhill SavPhill requested a review from ndiego as a code owner June 9, 2023 06:05
@SavPhill
Copy link
Contributor Author

SavPhill commented Jun 9, 2023

Hey there. Can you try merging in latest trunk? Right now, some of the automated items have failed/didn't report and it's making it so it can't be merged.

Hi, thank you. I pushed the latest trunk. Looks like some tests are slow to complete.

@skorasaurus skorasaurus added [Type] Developer Documentation Documentation for developers and removed Needs User Documentation Needs new user documentation labels Jun 9, 2023
@SavPhill
Copy link
Contributor Author

SavPhill commented Jul 7, 2023

Bump to reduce stagnation. Any further feedback for this PR?

@mburridge
Copy link
Contributor

mburridge commented Jul 10, 2023

Some tests were failing, and it's not possible to re-run the tests now as more than 30 days have passed. Could you merge the latest trunk into the branch and try again.

@ryanwelcher
Copy link
Contributor

ryanwelcher commented Jul 10, 2023

I've taken the liberty of updating this branch with latest trunk to re-trigger the tests. If any fail at this point, we should be able to re-run then. Sorry for the delay on this @SavPhill, we'll get this merged ASAP!

@annezazu annezazu merged commit 7b6c184 into WordPress:trunk Jul 10, 2023
46 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 10, 2023
@SavPhill
Copy link
Contributor Author

I've taken the liberty of updating this branch with latest trunk to re-trigger the tests. If any fail at this point, we should be able to re-run then. Sorry for the delay on this @SavPhill, we'll get this merged ASAP!

Thank you @ryanwelcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
6 participants