Navigation: Fix overflowing menu name in the navigation selector dropdown #45647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
getdave
reviewed
Nov 9, 2022
|
@getdave, thanks for the review. It looks like I had accidentally deleted one of the properties before committing the changes. I've added it back so it should now be working as expected. Could you pull the changes and take another look? |
yuliyan
requested review from
getdave
and removed request for
tellthemachines
getdave
approved these changes
Nov 9, 2022
| @@ -158,7 +157,7 @@ $colors-selector-size: 22px; | |||
| min-width: $colors-selector-size; | |||
| height: $colors-selector-size; | |||
| min-height: $colors-selector-size; | |||
| line-height: ( $colors-selector-size - 2 ); | |||
| line-height: ($colors-selector-size - 2); | |||
There was a problem hiding this comment.
Suggested change
| line-height: ($colors-selector-size - 2); | |
| line-height: ( $colors-selector-size - 2 ); |
This change seems unrelated.
Comment on lines
204
to
206
| .wp-block-navigation | ||
| .wp-block + .block-list-appender | ||
| .block-editor-button-block-appender { |
There was a problem hiding this comment.
Seems like another unrelated formatting change we should revert
Comment on lines
392
to
394
| .wp-block-navigation | ||
| .components-placeholder.is-medium | ||
| .components-placeholder__fieldset { |
There was a problem hiding this comment.
And one more unrelated formatting change...
Comment on lines
574
to
575
| .wp-block-navigation | ||
| .wp-block-navigation__uncontrolled-inner-blocks-loading-indicator { |
getdave
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the overflowing text in the navigation selector dropdown for menus with longer names.
Why?
It resolves the UI bug with the navigation selector dropdown reported in #45294.
How?
This PR wraps the text for the selected menu within the navigation selector dropdown toggle, so that flex and text CSS properties can be applied to avoid the overflowing.
Testing Instructions
Screenshots or screencast
Before:
After:
