Components: fix useCx story to satisfy exhaustive-deps eslint rule
#45614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
flootr
force-pushed
the
refactor/useCx-story-exhaustive-deps
branch
from
fcc15b9
to
41a2733
Compare
44 tasks
|
Merged, failing e2e tests were not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure
useCxstories satisfy theexhaustive-depseslint rule.Why?
Part of the effort in #41166 to apply
exhaustive-depsto the Components packageHow?
The
useCxutility includes a story with baduseMemousages. In this case the missing dependency is expected and therefore we intend ignore it but it's on the wrong line.Move the
eslint-disable-next-linecomment to the correct line.Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/utils/hooks/stories/use-cx.js