CardHeader used instead of CardFooter #45585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
carolinan
approved these changes
Nov 9, 2022
skorasaurus
approved these changes
Dec 30, 2022
|
Gentle reminder about this PR not yet merged. Please share if anything need from my side. Thanks. |
annezazu
approved these changes
Jun 5, 2023
|
Hey there. Can you try merging in latest trunk? Right now, some of the automated items have failed/didn't report and it's making it so it can't be merged. |
|
@annezazu synced with latest trunk, thanks. |
|
GitHub Action seemed to have stopped, but after closing and reopening this PR, it seems to have started working again. I also think this change makes sense, so I'm merging it. @gvgvgvijayan Thanks for your contribution! |
|
Thanks for rechecking @t-hamano 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
CardHeader used instead of CardFooter at the last sub/child component of Card component
Why?
Give correct sample of Card and it's sub component usage.