Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pocket Casts embed block variation #41006

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Add Pocket Casts embed block variation #41006

merged 3 commits into from
Jun 22, 2022

Conversation

phcp
Copy link
Contributor

@phcp phcp commented May 11, 2022 •
edited
Loading

What?

Introduces the embed block variation for Pocket Casts (WP55860).

Why?

To enable embedding Pocket Casts on WordPress posts using blocks.

How?

Adding the variation attributes for the Pocket Casts in the embed block variations array, also adding the Pocket Casts icon on the embed icons file.

Testing Instructions

By adding the Pocket Casts block

  1. Create an empty post
  2. Add the Pocket Casts block
  3. Enter a Pocket Casts URL
    3.1. Examples: https://pca.st/k2rof194, https://pca.st/qekyjgs6, https://pca.st/63wN
  4. Click on Embed
  5. Check if the Pocket Casts player is displayed

By pasting a Pocket Casts URL

  1. Create an empty post
  2. Paste a Pocket Casts URL in the content editor
    2.1. Examples: https://pca.st/k2rof194, https://pca.st/qekyjgs6, https://pca.st/63wN
  3. Check if the URL is replaced by the Pocket Casts player

Screenshots

Screen Shot 2022-05-30 at 14 04 30

Screen Shot 2022-05-30 at 14 10 51

Screen Shot 2022-05-30 at 12 31 13
@phcp phcp requested a review from ajitbohra as a code owner May 11, 2022 19:07
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 11, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @phcp! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
@skorasaurus skorasaurus added the [Block] Embed Affects the Embed Block label May 11, 2022
@gziolo gziolo added the [Feature] Block Variations Block variations, including introducing new variations and variations as a feature label May 12, 2022
@yansern yansern added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 17, 2022
@yansern yansern changed the title Add Pocket Casts embed block variation May 17, 2022
@yansern yansern marked this pull request as draft May 17, 2022 12:20
This was referenced May 19, 2022
Closed
Merged
@phcp
Add Pocket Casts embed block variation
181ab97 
* Add embed block variation for Pocket Casts

* Add the Pocket Casts icon on embed icons file
@phcp phcp changed the title [WIP] Add Pocket Casts embed block variation May 30, 2022
@phcp phcp marked this pull request as ready for review May 30, 2022 16:24
@yansern yansern removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 30, 2022
@phcp
Update Pocket Casts embed block variation
66400ad 
* Update the block description

* Add audio keywork to the block

* Change the Pocket Casts icon to use the brand color
@phcp phcp requested a review from mtias June 15, 2022 20:31
@peterwilsoncc
Copy link
Contributor

The WP trac ticket was originally closed due to auto-discovery working.

I've reopened it pending the inclusion of a block (WP#55860 (comment)). Once this PR is merged I will add the trac ticket to the next milestone.
@yansern yansern merged commit 665d78f into WordPress:trunk Jun 22, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @phcp! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 22, 2022
@bph bph added the Needs User Documentation Needs new user documentation label Aug 3, 2022
@femkreations femkreations mentioned this pull request Oct 4, 2022
Closed
11 tasks
@desrosj
Copy link
Contributor

desrosj commented Oct 21, 2022

@phcp While collecting props and credits for 6.1, it seems you are one of a few dozen folks that have not connected their WordPress.org account to their GitHub profile.

Could you share your WordPress.org account so that we can ensure you're properly credited on the About page for WordPress 6.1? Connecting your accounts will also help those collecting this in the future. Thanks in advance!
@phcp
Copy link
Contributor Author

phcp commented Oct 21, 2022

@desrosj My WordPress.org account is paulohcruz, and now it's connected with my GH account. Thank you!
@wayneconnor
Copy link

""need to subscribe to a premium Pocket Casts account to add your favorite or own Pocket Casts content into the block"

Am I reading this correctly?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs User Documentation Needs new user documentation
9 participants
@phcp @peterwilsoncc @desrosj @wayneconnor @mtias @bph @gziolo @skorasaurus @yansern