Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore descriptions for deprecated button props #37690

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

koen12344
Copy link
Contributor

Description

I found the llack of documentation on the recently deprecated button props confusing, so I added them back into the documentation and marked them as deprecated.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @koen12344! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added [Type] Developer Documentation Documentation for developers [Block] Buttons Affects the Buttons Block labels Jan 5, 2022
@t-hamano t-hamano added [Package] Components /packages/components and removed [Block] Buttons Affects the Buttons Block labels Dec 8, 2023
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks! Sorry this PR got lost in the pile.

@koen12344 Are you still available to resolve the conflict (and alphabetical order)?

@koen12344
Copy link
Contributor Author

koen12344 commented Dec 20, 2023

@mirka done, I have fixed the conflicts and alphabetized the deprecated props

@mirka
Copy link
Member

mirka commented Dec 20, 2023

Perfect, thanks!

@mirka mirka merged commit 7ecbbe8 into WordPress:trunk Dec 20, 2023
48 of 50 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
4 participants