Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsxBracketSameLine to renamed bracketSameLine #37517

Closed
wants to merge 1 commit into from

Conversation

waviaei
Copy link
Contributor

@waviaei waviaei commented Dec 20, 2021

Description

For #37516

How has this been tested?

Screenshots

Types of changes

Renamed jsxBracketSameLine option to bracketSameLine as per change in Prittier.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
@gziolo
Copy link
Member

gziolo commented Dec 20, 2021

@waviaei, thank you for the report. We are using a fork of Prettier in WordPress:

"prettier": "npm:wp-prettier@2.2.1-beta-1",

It's pinned to an older version so it still uses the old flag name. It's about time to make a hard decision and change the existing JavaScript coding styles for WordPress to align with what the original Prettier can support. That's the only way to always stay at the most recent version of Prettier.

Related issue: #21872.

@gziolo gziolo added [Package] Prettier config /packages/prettier-config [Type] Enhancement A suggestion for improvement. labels Dec 20, 2021
@gziolo gziolo added this to In progress in Core JS Dec 20, 2021
@gziolo
Copy link
Member

gziolo commented Dec 23, 2021

I opened #37607 to start making the official proposal to switch to the original Prettier in the most recent 2.5 version. The PR is gigantic and requires input from the WordPress community. It includes also the changes proposed in this PR.

@gziolo
Copy link
Member

gziolo commented Apr 20, 2022

I have an alternative PR that would make the config compatible with both Prettier and the WordPress specific fork at #40479. Thank you for raising this issue. I will close this PR.

@gziolo gziolo closed this Apr 20, 2022
@gziolo gziolo moved this from In progress to Done in Core JS Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Prettier config /packages/prettier-config [Type] Enhancement A suggestion for improvement.
2 participants